feat/cli: allow to extract the default seccomp profile #8800
Conversation
Signed-off-by: Bernhard Schuster <[email protected]>
| @@ -74,3 +78,27 @@ func (cmd *GenerateKeyCommand) Execute(args []string) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| type ExtractInternalConfigCommand struct { | |||
| FilePath string `short:"f" long:"filename" required:"true" description:"File path where the key shall be created. When generating ssh keys, the public key will be stored in a file with the same name but with '.pub' appended."` | |||
There was a problem hiding this comment.
The description here appears to not be updated. It talks about ssh keys but it looks like it's actually the destination you want the seccomp profile written to.
There was a problem hiding this comment.
Maybe change the longname to something else to, like output-file.
| @@ -74,3 +78,27 @@ func (cmd *GenerateKeyCommand) Execute(args []string) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| type ExtractInternalConfigCommand struct { | |||
There was a problem hiding this comment.
Feels weird having this sub-command in this file. Would make more sense to have it in its own file. wdyt?
| func (cmd *ExtractInternalConfigCommand) Execute(args []string) error { | ||
| var dest = cmd.FilePath | ||
| if cmd.Seccomp { | ||
| seccompfilter := bespec.GetDefaultSeccompProfile() |
There was a problem hiding this comment.
So the whole point of this command is to print the seccomp variable from https://github.com/concourse/concourse/blob/master/worker/runtime/spec/seccomp.go in json format?
There was a problem hiding this comment.
Yes, because that's what then could be modified and re-used as baseline for custom trim down or extension based on use case and re-supplied to the containerd runner
Changes proposed by this PR
Notes to reviewer
The main use-case is to extend/modify/limit these based on requirements, but provide them as a reasonable baseline for custom modifications. Prime use case is performance counters.
Release Note