set_pipeline step supports detach mode

atc/builds/planner.go

@@ -264,6 +264,7 @@ func (visitor *planVisitor) VisitSetPipeline(step *atc.SetPipelineStep) error {
  Vars: step.Vars,
  VarFiles: step.VarFiles,
  InstanceVars: step.InstanceVars,
+ Detach: step.Detach,
  })
 
  return nil

atc/db/build.go

@@ -212,6 +212,7 @@ type Build interface {
  config atc.Config,
  from ConfigVersion,
  initiallyPaused bool,
+ detach bool,
  ) (Pipeline, bool, error)
 
  ResourceCacheUser() ResourceCacheUser
@@ -1799,6 +1800,7 @@ func (b *build) SavePipeline(
  config atc.Config,
  from ConfigVersion,
  initiallyPaused bool,
+ detach bool,
 ) (Pipeline, bool, error) {
  tx, err := b.conn.Begin()
  if err != nil {
@@ -1807,8 +1809,14 @@ func (b *build) SavePipeline(
 
  defer Rollback(tx)
 
- jobID := newNullInt64(b.jobID)
- buildID := newNullInt64(b.id)
+ var jobID, buildID sql.NullInt64
+ if detach {
+ jobID = sql.NullInt64{Valid: false}
+ buildID = sql.NullInt64{Valid: false}
+ } else {
+ jobID = newNullInt64(b.jobID)
+ buildID = newNullInt64(b.id)
+ }
  pipelineID, isNewPipeline, err := savePipeline(tx, pipelineRef, config, from, initiallyPaused, teamID, jobID, buildID)
  if err != nil {
  return nil, false, err

atc/db/build_in_memory_check.go

@@ -662,7 +662,7 @@ func (b *inMemoryCheckBuild) Start(atc.Plan) (bool, error) {
 func (b *inMemoryCheckBuild) ResourcesChecked() (bool, error) {
  return false, errors.New("not implemented for in memory build")
 }
-func (b *inMemoryCheckBuild) SavePipeline(atc.PipelineRef, int, atc.Config, ConfigVersion, bool) (Pipeline, bool, error) {
+func (b *inMemoryCheckBuild) SavePipeline(atc.PipelineRef, int, atc.Config, ConfigVersion, bool, bool) (Pipeline, bool, error) {
  return nil, false, errors.New("not implemented for in memory build")
 }
 func (b *inMemoryCheckBuild) AdoptInputsAndPipes() ([]BuildInput, bool, error) {

atc/db/build_test.go

@@ -806,7 +806,7 @@ var _ = Describe("Build", func() {
  BeforeEach(func() {
  By("creating a child pipeline")
  build, _ := defaultJob.CreateBuild(defaultBuildCreatedBy)
- childPipeline, _, _ = build.SavePipeline(atc.PipelineRef{Name: "child1-pipeline"}, defaultTeam.ID(), defaultPipelineConfig, db.ConfigVersion(0), false)
+ childPipeline, _, _ = build.SavePipeline(atc.PipelineRef{Name: "child1-pipeline"}, defaultTeam.ID(), defaultPipelineConfig, db.ConfigVersion(0), false, false)
  build.Finish(db.BuildStatusSucceeded)
 
  childPipeline.Reload()
@@ -831,7 +831,7 @@ var _ = Describe("Build", func() {
  for i := 0; i < 5; i++ {
  job, _, _ := childPipeline.Job("some-job")
  build, _ := job.CreateBuild(defaultBuildCreatedBy)
- childPipeline, _, _ = build.SavePipeline(atc.PipelineRef{Name: "child-pipeline-" + strconv.Itoa(i)}, defaultTeam.ID(), defaultPipelineConfig, db.ConfigVersion(0), false)
+ childPipeline, _, _ = build.SavePipeline(atc.PipelineRef{Name: "child-pipeline-" + strconv.Itoa(i)}, defaultTeam.ID(), defaultPipelineConfig, db.ConfigVersion(0), false, false)
  build.Finish(db.BuildStatusSucceeded)
  childPipelines = append(childPipelines, childPipeline)
  }
@@ -2393,7 +2393,7 @@ var _ = Describe("Build", func() {
  },
  },
  },
- }, db.ConfigVersion(0), false)
+ }, db.ConfigVersion(0), false, false)
  Expect(err).ToNot(HaveOccurred())
  Expect(pipeline.ParentJobID()).To(Equal(build.JobID()))
  Expect(pipeline.ParentBuildID()).To(Equal(build.ID()))
@@ -2431,7 +2431,7 @@ var _ = Describe("Build", func() {
  },
  },
  },
- }, db.ConfigVersion(0), false)
+ }, db.ConfigVersion(0), false, false)
  Expect(err).ToNot(HaveOccurred())
  Expect(pipeline.ParentJobID()).To(Equal(buildTwo.JobID()))
  Expect(pipeline.ParentBuildID()).To(Equal(buildTwo.ID()))
@@ -2461,7 +2461,7 @@ var _ = Describe("Build", func() {
  },
  },
  },
- }, pipeline.ConfigVersion(), false)
+ }, pipeline.ConfigVersion(), false, false)
  Expect(err).To(Equal(db.ErrSetByNewerBuild))
  })
 
@@ -2472,7 +2472,7 @@ var _ = Describe("Build", func() {
  Expect(err).ToNot(HaveOccurred())
 
  By("re-saving the default pipeline with the build")
- pipeline, _, err := build.SavePipeline(defaultPipelineRef, build.TeamID(), defaultPipelineConfig, db.ConfigVersion(1), false)
+ pipeline, _, err := build.SavePipeline(defaultPipelineRef, build.TeamID(), defaultPipelineConfig, db.ConfigVersion(1), false, false)
  Expect(err).ToNot(HaveOccurred())
  Expect(pipeline.ParentJobID()).To(Equal(build.JobID()))
  Expect(pipeline.ParentBuildID()).To(Equal(build.ID()))
@@ -2493,7 +2493,7 @@ var _ = Describe("Build", func() {
  By("setting the pipeline again via a build")
  build, err := defaultJob.CreateBuild(defaultBuildCreatedBy)
  Expect(err).ToNot(HaveOccurred())
- pipeline, _, err = build.SavePipeline(defaultPipelineRef, build.TeamID(), defaultPipelineConfig, pipeline.ConfigVersion(), false)
+ pipeline, _, err = build.SavePipeline(defaultPipelineRef, build.TeamID(), defaultPipelineConfig, pipeline.ConfigVersion(), false, false)
  Expect(err).ToNot(HaveOccurred())
 
  Expect(pipeline.Paused()).To(BeFalse())
@@ -2513,7 +2513,7 @@ var _ = Describe("Build", func() {
  By("setting the pipeline again via a build")
  build, err := defaultJob.CreateBuild(defaultBuildCreatedBy)
  Expect(err).ToNot(HaveOccurred())
- pipeline, _, err = build.SavePipeline(defaultPipelineRef, build.TeamID(), defaultPipelineConfig, pipeline.ConfigVersion(), false)
+ pipeline, _, err = build.SavePipeline(defaultPipelineRef, build.TeamID(), defaultPipelineConfig, pipeline.ConfigVersion(), false, false)
  Expect(err).ToNot(HaveOccurred())
 
  Expect(pipeline.Paused()).To(BeTrue())

atc/db/pipeline.go

@@ -127,6 +127,7 @@ type Pipeline interface {
  Variables(lager.Logger, creds.Secrets, creds.VarSourcePool) (vars.Variables, error)
 
  SetParentIDs(jobID, buildID int) error
+ DetachParent() error
 }
 
 type pipeline struct {
@@ -1168,6 +1169,39 @@ func (p *pipeline) Variables(logger lager.Logger, globalSecrets creds.Secrets, v
  return allVars, nil
 }
 
+func (p *pipeline) DetachParent() error {
+ tx, err := p.conn.Begin()
+ if err != nil {
+ return err
+ }
+
+ defer Rollback(tx)
+
+ nullID := sql.NullInt64{Valid: false}
+ result, err := psql.Update("pipelines").
+ Set("parent_job_id", nullID).
+ Set("parent_build_id", nullID).
+ Where(sq.Eq{
+ "id": p.id,
+ }).
+ RunWith(tx).
+ Exec()
+
+ if err != nil {
+ return err
+ }
+
+ rows, err := result.RowsAffected()
+ if err != nil {
+ return err
+ }
+ if rows == 0 {
+ return ErrSetByNewerBuild
+ }
+
+ return tx.Commit()
+}
+
 func (p *pipeline) SetParentIDs(jobID, buildID int) error {
  if jobID <= 0 || buildID <= 0 {
  return errors.New("job and build id cannot be negative or zero-value")

atc/db/pipeline_lifecycle_test.go

@@ -35,7 +35,7 @@ var _ = Describe("PipelineLifecycle", func() {
 
  BeforeEach(func() {
  setChildBuild, _ = defaultJob.CreateBuild(defaultBuildCreatedBy)
- childPipeline, _, _ = setChildBuild.SavePipeline(atc.PipelineRef{Name: "child-pipeline"}, defaultTeam.ID(), defaultPipelineConfig, db.ConfigVersion(0), false)
+ childPipeline, _, _ = setChildBuild.SavePipeline(atc.PipelineRef{Name: "child-pipeline"}, defaultTeam.ID(), defaultPipelineConfig, db.ConfigVersion(0), false, false)
  setChildBuild.Finish(db.BuildStatusSucceeded)
  })
 

atc/exec/set_pipeline_step.go

@@ -133,8 +133,13 @@ func (step *SetPipelineStep) run(ctx context.Context, state RunState, delegate S
  }
 
  var team db.Team
+ var detach bool
  if step.plan.Team == "" {
  team = step.teamFactory.GetByID(step.metadata.TeamID)
+ // When team is not specified, target team equals to current team.
+ if team.Admin(){
+ detach = step.plan.Detach
+ }
  } else {
  fmt.Fprintln(stderr, "\x1b[1;33mWARNING: specifying the team in a set_pipeline step is experimental and may be removed in the future!\x1b[0m")
  fmt.Fprintln(stderr, "")
@@ -163,6 +168,7 @@ func (step *SetPipelineStep) run(ctx context.Context, state RunState, delegate S
  }
  if currentTeam.Admin() {
  permitted = true
+ detach = step.plan.Detach
  }
  if !permitted {
  return false, fmt.Errorf(
@@ -174,6 +180,13 @@ func (step *SetPipelineStep) run(ctx context.Context, state RunState, delegate S
  team = targetTeam
  }
 
+ if detach != step.plan.Detach {
+ return false, fmt.Errorf(
+ "only %s team can set detached pipeline",
+ atc.DefaultTeamName,
+ )
+ }
+
  pipelineRef := atc.PipelineRef{
  Name: step.plan.Name,
  InstanceVars: step.plan.InstanceVars,
@@ -202,7 +215,12 @@ func (step *SetPipelineStep) run(ctx context.Context, state RunState, delegate S
  fmt.Fprintf(stdout, "no changes to apply.\n")
 
  if found {
- err := pipeline.SetParentIDs(step.metadata.JobID, step.metadata.BuildID)
+ var err error
+ if detach {
+ err = pipeline.DetachParent()
+ } else {
+ err = pipeline.SetParentIDs(step.metadata.JobID, step.metadata.BuildID)
+ }
  if err != nil {
  return false, err
  }
@@ -230,7 +248,7 @@ func (step *SetPipelineStep) run(ctx context.Context, state RunState, delegate S
  return false, fmt.Errorf("set_pipeline step not attached to a buildID")
  }
 
- pipeline, _, err = parentBuild.SavePipeline(pipelineRef, team.ID(), atcConfig, fromVersion, false)
+ pipeline, _, err = parentBuild.SavePipeline(pipelineRef, team.ID(), atcConfig, fromVersion, false, detach)
  if err != nil {
  if err == db.ErrSetByNewerBuild {
  fmt.Fprintln(stderr, "\x1b[1;33mWARNING: the pipeline was not saved because it was already saved by a newer build\x1b[0m")