concourse#5215 fly: add --team flag to set-pipelines #5805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thx for the PR. Could you add a release note for this feature? |
|
Just added, good catch! 馃槃 |
document DCO process Signed-off-by: jroden <[email protected]>
|
Rebased commits, added DCO 馃槄 |
|
@jroden there is conlict in release-notes |
document DCO process Signed-off-by: jroden <[email protected]>
|
Just merged upstream to resolve the conflict-- let me know if there's anything else. Thanks! |
xtreme-sameer-vohra
added
the
release/undocumented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
document DCO process
Signed-off-by: jroden [email protected]
What does this PR accomplish?
Feature
closes # .
Changes proposed by this PR:
Currently the only way for users to set pipelines from different teams with Fly is to create multiple targets. With this addition users can now set pipelines against different teams within a target. This is part of the #5215 checklist.
Notes to reviewer:
First time contributor here, thanks for the help! 馃槃 Pretty straightforward addition code-wise. For testing, can run the specific ginkgo case as needed with
ginkgo --focus='when setting new pipeline with non-default team'Contributor Checklist
Reviewer Checklist
BOSH and
Helm packaging; otherwise, ignored for
the integration
tests
(for example, if they are Garden configs that are not displayed in the
--helptext).