Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conjur credential manager provide certificate as string #5702

Conversation

AndrewCopeland
Copy link
Contributor

Signed-off-by: AndrewCopeland [email protected]

What does this PR accomplish?

Bug Fix

Adds the ability to provide CA certificate as a string for the conjur credential manager.

closes #5701 .

Changes proposed by this PR:

Add ability to provide the ca certificate as a string. Currently certificate must be provided as a file.

Notes to reviewer:

Relates to this Issue: concourse/concourse-bosh-release#105

Contributor Checklist

Reviewer Checklist

  • Code reviewed
  • Tests reviewed
  • Documentation reviewed
  • Release notes reviewed
  • PR acceptance performed
  • New config flags added? Ensure that they are added to the
    BOSH and
    Helm packaging; otherwise, ignored for
    the integration
    tests

    (for example, if they are Garden configs that are not displayed in the
    --help text).

@AndrewCopeland AndrewCopeland requested a review from a team June 1, 2020 16:54
@vito vito self-assigned this Jun 2, 2020
@vito vito added this to the v6.3.0 milestone Jun 2, 2020
@vito
Copy link
Member

vito commented Jun 4, 2020

Replied here: concourse/concourse-bosh-release#106 (comment) - I think this change won't be necessary if we use env_file: in the BOSH release. 🙂 Thanks!

@vito vito closed this Jun 4, 2020
@scottietremendous scottietremendous removed this from the v6.3.0 milestone Jun 4, 2020
@clarafu clarafu added the release/no-impact This is an issue that never affected released versions (i.e. a regression caught prior to shipping). label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/no-impact This is an issue that never affected released versions (i.e. a regression caught prior to shipping).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conjur Credential Manager certificate as String
4 participants