Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hermes: add recipe #24010

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions recipes/hermes/all/conandata.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
sources:
"2024.04.29":
url: "https://github.com/facebook/hermes/archive/refs/tags/hermes-2024-04-29-RNv0.73.8-644c8be78af1eae7c138fa4093fb87f0f4f8db85.tar.gz"
sha256: "f49f3e1115fcf96399b673bfbf05a4fb07334def9ffe6ae7eb692ad9ba27a3a8"
95 changes: 95 additions & 0 deletions recipes/hermes/all/conanfile.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
from conan import ConanFile
from conan.errors import ConanInvalidConfiguration
from conan.tools.files import get, copy
from conan.tools.build import check_min_cppstd
from conan.tools.env import VirtualBuildEnv
from conan.tools.scm import Version
from conan.tools.cmake import CMake, CMakeDeps, CMakeToolchain, cmake_layout
import os

required_conan_version = ">=1.53.0"

class HermesConan(ConanFile):
name = "hermes"
description = "A JavaScript engine optimized for running React Native."
license = "MIT"
url = "https://github.com/conan-io/conan-center-index"
homepage = "https://github.com/facebook/hermes"
topics = ("javascript", "ahead-of-time", "react native")
package_type = "library"
settings = "os", "arch", "compiler", "build_type"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing package_type :)

options = {
"shared": [True, False],
"fPIC": [True, False],
}
default_options = {
"shared": False,
"fPIC": True,
}

@property
def _min_cppstd(self):
return 14

@property
def _compilers_minimum_version(self):
return {
"gcc": "7",
"clang": "7",
"apple-clang": "10",
"Visual Studio": "15",
"msvc": "191",
}

def config_options(self):
if self.settings.os == "Windows":
del self.options.fPIC

def configure(self):
if self.options.shared:
self.options.rm_safe("fPIC")

def layout(self):
cmake_layout(self, src_folder="src")

def requirements(self):
self.requires("icu/74.2")
RubenRBS marked this conversation as resolved.
Show resolved Hide resolved

def validate(self):
if self.settings.compiler.cppstd:
check_min_cppstd(self, self._min_cppstd)
minimum_version = self._compilers_minimum_version.get(str(self.settings.compiler), False)
if minimum_version and Version(self.settings.compiler.version) < minimum_version:
raise ConanInvalidConfiguration(
f"{self.ref} requires C++{self._min_cppstd}, which your compiler does not support."
)

def build_requirements(self):
self.tool_requires("cpython/3.12.2")

def source(self):
get(self, **self.conan_data["sources"][self.version], strip_root=True)

def generate(self):
tc = CMakeToolchain(self)
tc.cache_variables["BUILD_SHARED_LIBS"] = self.options.shared
tc.variables["HERMES_USE_STATIC_ICU"] = not self.dependencies["icu"].options.shared
tc.variables["HERMES_ENABLE_TEST_SUITE"] = False
tc.generate()
deps = CMakeDeps(self)
deps.generate()
venv = VirtualBuildEnv(self)
venv.generate(scope="build")

def build(self):
cmake = CMake(self)
cmake.configure()
cmake.build()

def package(self):
copy(self, pattern="LICENSE", dst=os.path.join(self.package_folder, "licenses"), src=self.source_folder)
cmake = CMake(self)
cmake.install()

def package_info(self):
self.cpp_info.libs = ["hermes"]
24 changes: 24 additions & 0 deletions recipes/hermes/all/patches/0001-include-cstdint.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
diff --git a/include/hermes/Support/SHA1.h b/include/hermes/Support/SHA1.h
index cfc82b4..80da5df 100644
--- a/include/hermes/Support/SHA1.h
+++ b/include/hermes/Support/SHA1.h
@@ -10,6 +10,7 @@

#include <array>
#include <string>
+#include <cstdint>

namespace hermes {

diff --git a/public/hermes/Public/DebuggerTypes.h b/public/hermes/Public/DebuggerTypes.h
index fe65180..977b6e0 100644
--- a/public/hermes/Public/DebuggerTypes.h
+++ b/public/hermes/Public/DebuggerTypes.h
@@ -10,6 +10,7 @@

#include <string>
#include <vector>
+#include <cstdint>

namespace hermes {
namespace vm {
8 changes: 8 additions & 0 deletions recipes/hermes/all/test_package/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
cmake_minimum_required(VERSION 3.15)
project(test_package LANGUAGES CXX)

find_package(hermes REQUIRED CONFIG)

add_executable(${PROJECT_NAME} test_package.cpp)
target_link_libraries(${PROJECT_NAME} PRIVATE hermes::hermes)
target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_14)
26 changes: 26 additions & 0 deletions recipes/hermes/all/test_package/conanfile.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
from conan import ConanFile
from conan.tools.build import can_run
from conan.tools.cmake import cmake_layout, CMake
import os


class TestPackageConan(ConanFile):
settings = "os", "arch", "compiler", "build_type"
generators = "CMakeDeps", "CMakeToolchain", "VirtualRunEnv"
test_type = "explicit"

def requirements(self):
self.requires(self.tested_reference_str)

def layout(self):
cmake_layout(self)

def build(self):
cmake = CMake(self)
cmake.configure()
cmake.build()

def test(self):
if can_run(self):
bin_path = os.path.join(self.cpp.build.bindir, "test_package")
self.run(bin_path, env="conanrun")
11 changes: 11 additions & 0 deletions recipes/hermes/all/test_package/test_package.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#include "hermes/hermes.h"
#include "hermes/Public/RuntimeConfig.h"

int main() {
hermes::vm::RuntimeConfig config;
auto rt = facebook::hermes::makeHermesRuntime(config);

rt->global().getPropertyAsFunction(*rt, "eval").call(*rt, "var q = 0;");

return 0;
}
3 changes: 3 additions & 0 deletions recipes/hermes/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
versions:
"2024.04.29":
folder: all