Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) feat: Manifest status (Plan to add status of manifests) #423

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shawn111
Copy link
Contributor

@shawn111 shawn111 commented May 2, 2024

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

comtrya apply --dry-run could provide some manifests information but not easy to map to manifests.

What is the motivation / use case for changing the behavior?

I added count of actions as beginning, can add other information later.

$ comtrya status
Load manifests from path: "/home/shawn/.dotfiles/collections/kubernetes"

+-------------------+------------------+
| Manifest          | Count of Actions |
+======================================+
| kubectl.krew      | 3                |
|-------------------+------------------|
| kubectl.kubesess  | 3                |
|-------------------+------------------|
| kdash.kdash       | 1                |
+-------------------+------------------+

- cargo add clap_complete
- move commands related code into commands::mods.rs to simplify main.rs
Plan to add status of manifests
@shawn111 shawn111 changed the title feat: Manifest status (Plan to add status of manifests) (WIP) feat: Manifest status (Plan to add status of manifests) May 2, 2024
@shawn111 shawn111 marked this pull request as draft May 2, 2024 08:29
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 28.10%. Comparing base (b574682) to head (6c7e183).
Report is 18 commits behind head on main.

Files Patch % Lines
app/src/commands/apply.rs 0.00% 21 Missing ⚠️
app/src/commands/mod.rs 0.00% 7 Missing ⚠️
app/src/commands/gen_completions.rs 0.00% 5 Missing ⚠️
app/src/main.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   28.59%   28.10%   -0.50%     
==========================================
  Files          85       87       +2     
  Lines        2301     2334      +33     
==========================================
- Hits          658      656       -2     
- Misses       1643     1678      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants