Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace structopt/paw with clap #419

Merged
merged 1 commit into from May 1, 2024
Merged

Conversation

shawn111
Copy link
Contributor

@shawn111 shawn111 commented Apr 30, 2024

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

As https://github.com/TeXitoi/structopt mention clap already support derive and structopt would not add new features.

What is the motivation / use case for changing the behavior?

Switch to clap, clean some dependency.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 28.43%. Comparing base (b574682) to head (86e16dd).
Report is 17 commits behind head on main.

Files Patch % Lines
app/src/main.rs 0.00% 3 Missing ⚠️
app/src/config/mod.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   28.59%   28.43%   -0.17%     
==========================================
  Files          85       85              
  Lines        2301     2307       +6     
==========================================
- Hits          658      656       -2     
- Misses       1643     1651       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawn111 shawn111 changed the title use clap replace structopt paw refactor: replace structopt/paw with clap Apr 30, 2024
Copy link
Contributor

@martintc martintc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I would like for @icepuma or @rawkode to also approve this before we pull it in in case they have some issue with replacing paw and structopt.

@shawn111
Copy link
Contributor Author

shawn111 commented May 1, 2024

clap_complete works. shawn111@465800a

but it rely on this PR.

@rawkode rawkode merged commit c095ed8 into comtrya:main May 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants