Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure the manifest name is the dependency prefix for local depe… #389

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Dec 29, 2023

…ndencies when at top level

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

Fixes #388

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Version (comtrya --version):
Operating system:

@rawkode rawkode requested review from a team, icepuma and martintc and removed request for a team December 29, 2023 22:43
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f4fd2c1) 28.26% compared to head (e6579c2) 28.26%.

Files Patch % Lines
app/src/commands/apply.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #389   +/-   ##
=======================================
  Coverage   28.26%   28.26%           
=======================================
  Files          85       85           
  Lines        2289     2289           
=======================================
  Hits          647      647           
  Misses       1642     1642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rawkode rawkode merged commit a5ff9be into main Dec 29, 2023
4 checks passed
@rawkode rawkode deleted the fix/local-dependency-without-real-hierarchy branch December 29, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Local Dependency Failure if no "real" hierarchy
3 participants