Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct error propagation from exec errors #387

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Dec 29, 2023

I'm submitting a

  • bug fix
  • feature
  • documentation addition

What is the current behaviour?

Closes #316

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Version (comtrya --version):
Operating system:

@rawkode rawkode requested review from icepuma, a team and martintc and removed request for a team December 29, 2023 21:55
@codecov-commenter
Copy link

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (2cf7391) 28.26% compared to head (7f73bb7) 28.59%.
Report is 3 commits behind head on main.

Files Patch % Lines
lib/src/atoms/command/exec.rs 18.75% 26 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   28.26%   28.59%   +0.33%     
==========================================
  Files          85       85              
  Lines        2289     2301      +12     
==========================================
+ Hits          647      658      +11     
- Misses       1642     1643       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rawkode rawkode merged commit b437590 into main Dec 29, 2023
4 checks passed
@rawkode rawkode deleted the fix/improve-command-exec-error-handling branch December 29, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: action with command that exits with errorcode ! 0 is reported as OK
3 participants