Fixed company-semantic-annotation, so that it .. #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. can appropriately deal with function pointers in C.
As an example of the original problem, consider the struct
struct blah {
int (*hates)(uint8_t, uint32_t);
void *blank;
}
the annotation returned by company-semantic-annotation would be
(*hates)(uint8_t, uint32_t)
which when coupled with the default value of 'company-semantic-insert-arguments'
yields decidedly annoying results.
This patch fixes the problem. Additionally. you can find a gallery
of screenshots illustrating the problem http://imgur.com/gallery/pyxwg
The issue with the original code seems to be the implicit assumption that the
type of blah::hates is not seen as a function by semantic. This is incorrect, as
semantic properly designates it a function-pointer which being callable, makes it
a function.
|
Thanks! This looks good, but a bit nontrivial. Could you add a couple of tests as well? |
|
Will do |
|
@differentiablef Ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. can appropriately deal with function pointers in C.
As an example of the original problem, consider the struct
struct blah { int (*hates)(uint8_t, uint32_t); void *blank; }the annotation returned by company-semantic-annotation for 'hates' would be
(*hates)(uint8_t, uint32_t)which when coupled with the default value of 'company-semantic-insert-arguments'
yields decidedly annoying results.
This patch fixes the problem. Additionally. I've attached a sequence of screenshots
illustrating the problem.
The issue with the original code seems to be the implicit assumption that the
type of blah::hates is not seen as a function by semantic. This is incorrect, as
semantic properly designates it a function-pointer which being callable, makes it
a function.