Async no cache flicker #1471
Merged
Async no cache flicker #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Employ the scheme previously devised by lsp-mode folks: keep the old list of completions (setting it to nil is what created the flicker) but updated the prefix. This is for "continue" case, of course. begin-new should still fail. #1468
The change in company-point setting will help when the condition for non-essential changes from "not explicit-action" to "not explicit-action now".
|
@yyoncho @kiennq I think you might be interested in this too, we discussed this kind of solution back in emacs-lsp/lsp-mode#1894, and this moves the same approach inside company-mode. |
As long as completion is `non-essential', of course. #1468 Resulting from this thread: https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01217.html This makes company-capf more compatible with Corfu, Cc @minad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while-no-inputfor company-capf which reuses the mechanism.(throw 'interrupted 'new-input)instead, if it detects new input using its own methods.I suppose the main thing left to decide is whetherwhile-no-inputshould be opt-in or opt-out for the capf backend.EDIT: just opt-out: see NEWS.