Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mill from 0.11.7-17-17dea9 to 0.11.7-109-59a5cb #3192

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lefou
Copy link
Member

@lefou lefou commented May 29, 2024

No description provided.

@@ -1,2 +1 @@
0.11.7-17-17dea9

0.11.7-109-59a5cb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a \n at the end

@lefou
Copy link
Member Author

lefou commented Jun 18, 2024

So, I tried to restart the build multiple times but it seems the failure isn't just flakiness but something else I still don't understand.

Looks like the produced assembly isn't executable.

> cmd /C %GITHUB_WORKSPACE%\ci\mill.bat -i -d -k "{main,scalalib,bsp}.__.test"
...
mill.scalalib.AssemblyTests: [55/55] exe.small.assembly 
File size: 10954343
<h1>tutu</h1>
X mill.scalalib.AssemblyTests.Assembly.exe.small 5445ms 
  java.io.IOException: Cannot run program "D:\a\mill\mill\target\workspace\mill\scalalib\AssemblyTests\eval\Assembly\exe\small\exe\small\assembly.dest\out.jar" (in directory "D:\a\mill\mill\target\worksources\mill\scalalib\AssemblyTests\TestCase"): CreateProcess error=193, %1 is not a valid Win32 application
    java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
    os.proc.proc$lzycompute$1(ProcessOps.scala:123)
    os.proc.proc$1(ProcessOps.scala:122)
    os.proc.spawn(ProcessOps.scala:129)
    mill.util.Jvm$.spawnSubprocessWithBackgroundOutputs(Jvm.scala:258)
    mill.util.Jvm$.runSubprocess(Jvm.scala:168)
    mill.scalalib.AssemblyTests$.runAssembly(AssemblyTests.scala:104)
    mill.scalalib.AssemblyTests$.$anonfun$tests$10(AssemblyTests.scala:129)
    mill.scalalib.AssemblyTests$.$anonfun$tests$10$adapted(AssemblyTests.scala:127)
    mill.scalalib.AssemblyTests$.workspaceTest(AssemblyTests.scala:89)
    mill.scalalib.AssemblyTests$.$anonfun$tests$9(AssemblyTests.scala:109)
  java.io.IOException: CreateProcess error=193, %1 is not a valid Win32 application
    java.lang.ProcessImpl.create(ProcessImpl.java:-2)
    java.lang.ProcessImpl.<init>(ProcessImpl.java:453)
    java.lang.ProcessImpl.start(ProcessImpl.java:139)
    java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
    os.proc.proc$lzycompute$1(ProcessOps.scala:123)
    os.proc.proc$1(ProcessOps.scala:122)
    os.proc.spawn(ProcessOps.scala:129)
    mill.util.Jvm$.spawnSubprocessWithBackgroundOutputs(Jvm.scala:258)
    mill.util.Jvm$.runSubprocess(Jvm.scala:168)
    mill.scalalib.AssemblyTests$.runAssembly(AssemblyTests.scala:104)
    mill.scalalib.AssemblyTests$.$anonfun$tests$10(AssemblyTests.scala:129)
    mill.scalalib.AssemblyTests$.$anonfun$tests$10$adapted(AssemblyTests.scala:127)
    mill.scalalib.AssemblyTests$.workspaceTest(AssemblyTests.scala:89)
    mill.scalalib.AssemblyTests$.$anonfun$tests$9(AssemblyTests.scala:109)

The bumped Mill version (the essence of this PR) contains also a fix for the assembly target, which should fail the target if a script-prepended assembly jar might be too big to be executable. Now, the strange thing is that the failing test is also about the assembly target, but only on Windows (which I haven't access to). I think the Mill under test and the actual executing Mill versions shouldn't influence each other, but I have no other explanation for the failing test.

@lefou lefou marked this pull request as draft June 18, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants