Fix add_field_serializer_for_reverse_relations clearing validators

[camillol]

When a model has a reverse relation, Ormar synthesizes a field for it. In order to get Pydantic to see the new field, it calls DecoratorInfos.build (in add_field_serializer_for_reverse_relations) to pick up the new serializer, and then model_rebuild. Unfortunately, DecoratorInfos.build is not idempotent. When it processes a model class, it collects the information in __pydantic_decorators__, and it strips out the decorators from the class members, to save time in case it has to process the class again (as the base class of a different class). If it is called again, it starts collecting the decorators from scratch, ignoring the existing __pydantic_decorators__. Since the class members have already had their decorators stripped, they are not collected again. The net result is that any pydantic decorators that had already been processed are lost.

This has the result of ignoring @field_validator etc. if a model has a reverse relation that is processed after the model.

This PR fixes the issue by storing the preexisting __pydantic_decorators__ and merging the new ones into it. This fix should keep working even if Pydantic changes DecoratorInfos.build to be idempotent.

[collerek]

sorry for the late answer, can you add a test that would fail before and this change fixes?

[codspeed-hq]

CodSpeed Performance Report

Merging #1302 will degrade performances by 12.51%

_{Comparing camillol:fixdescriptors (56a9d00) with master (7f3149d)}

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 82 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	master	camillol:fixdescriptors	Change
⚡	test_min[250]	3.6 ms	2.7 ms	+31.57%
❌	test_deleting_individually[10]	8.6 ms	9.8 ms	-12.51%

[camillol]

sorry for the late answer, can you add a test that would fail before and this change fixes?

Done!

[collerek]

Hi, you didn't allow me to push to your fork, so can you please apply b1d803a on your pr (fixes test with default value)

[camillol]

Done!