Skip to content

Commit

Permalink
Fix: Parse error on elements containing admin-data
Browse files Browse the repository at this point in the history
- Fix parse error when admin-data is encountered in XML
- Update version to 0.5.4a2
  • Loading branch information
cogu committed Apr 19, 2024
1 parent 379931e commit 66cd412
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ Non-collectable elements are various sub-elements to collectable elements.

## [Unreleased]

### Fixed

* Fixed parsing error on elements containing `ADMIN-DATA`.

### Changed

* Reader class attempts to resume parsing at next element if an error occurs.
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "autosar"
version = "0.5.4a1"
version = "0.5.4a2"
description = "A set of Python modules for working with AUTOSAR XML files"
readme = "README.md"
requires-python = ">=3.10"
Expand Down
2 changes: 2 additions & 0 deletions src/autosar/xml/element.py
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ def __init__(self,
desc: Union["MultiLanguageOverviewParagraph", tuple[ar_enum.Language, str], str, None] = None,
category: str | None = None,
uuid: str | None = None,
admin_data: Union["AdminData", None] = None,
**kwargs) -> None:
super().__init__(name, **kwargs)
self.desc: MultiLanguageOverviewParagraph | None = None
Expand All @@ -323,6 +324,7 @@ def __init__(self,
self.introduction = None
self.annotations = None
self.uuid = None
self.admin_data: Union["AdminData", None] = None
if desc is not None:
if isinstance(desc, MultiLanguageOverviewParagraph):
self.desc = desc
Expand Down
2 changes: 1 addition & 1 deletion src/autosar/xml/reader.py
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ def _read_admin_data(self, xml_element: ElementTree.Element) -> ar_element.Admin
element_map.skip('USED-LANGUAGES') # Implement later
element_map.skip('DOC-REVISIONS') # Implement later
xml_sdgs = element_map.get('SDGS')
if xml_sdgs:
if len(xml_sdgs):
data['data'] = self._read_admin_data_sdgs(xml_sdgs)
return ar_element.AdminData(**data)

Expand Down

0 comments on commit 66cd412

Please sign in to comment.