improvement: Reduce Memory overhead of default appearance array #3882
+32
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allocates an array of the size of the input texture. If we have over 8mill nodes this is about 67MB array allocated with repeating data We split it into multiple arrays to avoid memory, while keeping fast performance.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3882 +/- ##
==========================================
+ Coverage 73.54% 73.55% +0.01%
==========================================
Files 357 357
Lines 35855 35875 +20
Branches 2734 2734
==========================================
+ Hits 26369 26389 +20
Misses 9381 9381
Partials 105 105
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/
Description 📝
Today the default appearance array allocates an array of the size of the input texture. If we have over 8mill nodes this is about 67MB (4k x 4k x 4bytes) array allocated with the same 4 bytes repeated 16 million times.
We split it into multiple arrays to avoid memory waste, while also improving performance!
The PR is a bit WIP, as I need to test it a bit more. But currently this approach saves 10% time, and 95% memory on worst case performance (4k texture) compared to the old approach.
How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️