Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding show-urls argument to display just the URLs #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

koldbyte
Copy link

Added a new boolean argument --show-urls with default value false.

When set to true, it will display the URLs only and not start any downloads.

This will be very helpful when anybody wants to download through a download manager.

@coderick14
Copy link
Owner

Hey. Instead of adding the if condition inside the loop, can you just shift it to line 167 after the URL has been determined? You can just place the condition after the line

courseURL := courseBaseURL + *courseName

@koldbyte
Copy link
Author

koldbyte commented Jan 28, 2018

This will print the course URLs not the actual download links.

A better position could be just before the Line: 217 after which bars and WaitGroup has been initialised. I need to print the baseURL + paths[i] so I will have to add a loop again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants