CC-1296 Ensure tooltip is not affected by stylistic changes from button being disabled

[libmartinito]

Checklist:

• I've thoroughly self-reviewed my changes
• I've added tests for my changes, unless they affect admin-only areas (or are otherwise not worth testing)
• I've verified any visual changes using Percy (add a commit with [percy] in the message to trigger)

Summary by CodeRabbit

• New Features

  • Improved visual hierarchy in the username section of the profile settings page.
  • Added tooltips for GitHub profile information on hover.

• Tests

  • Enhanced test coverage for the profile settings page by including tooltip content assertion.

[linear]

CC-1296 Add "refresh from github" functionality to user settings page

[coderabbitai]

Walkthrough

The changes involve modifying the visual hierarchy and interaction of the username section on the settings profile page. Specifically, these updates include nesting elements in the <Settings::FormSection> and adding assertions and interactions in the tests. These adjustments aim to enhance the user interface and enhance test coverage for tooltip content and interactions on the profile page.

Changes

Files	Change Summary
app/components/settings/profile-page/...	Reordered and nested components in <Settings::FormSection>, wrapping <TertiaryButtonWithSpinner> in a <div>.
tests/acceptance/settings-page/profile-test.js	Imported assertTooltipContent and added an assertion for tooltip content after hovering over a related button.
tests/pages/settings/profile-page.ts	Added hover: triggerable('mouseenter') event to refreshFromGitHubButton.

Poem

In the realm of code, a rabbit's delight,
With shifts and clicks, we make things right.
Buttons now nest and hover with glee,
Tooltip whispers, "hover and see!"
Our tests grow stronger, our UI bright,
CodeRabbit dances in the moonlit night.
🌙✨🐇

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Bundle Report

Changes will increase total bundle size by 1.8kB ⬆️

Bundle name	Size	Change
client-array-push	26.02MB	1.8kB ⬆️

[github-actions]

Test Results

  1 files  ±0    1 suites  ±0   9m 49s ⏱️ - 1m 34s
539 tests ±0  504 ✅ +3  35 💤 ±0  0 ❌ ±0 
554 runs  ±0  519 ✅ +6  35 💤 ±0  0 ❌  - 3 

Results for commit ae99c0d. ± Comparison against base commit 36e599e.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 36e599e and ae99c0d.

Files selected for processing (3)

• app/components/settings/profile-page/username-section.hbs (2 hunks)
• tests/acceptance/settings-page/profile-test.js (2 hunks)
• tests/pages/settings/profile-page.ts (1 hunks)

Files skipped from review due to trivial changes (1)

• app/components/settings/profile-page/username-section.hbs

Additional context used

Biome

tests/acceptance/settings-page/profile-test.js

[error] 9-90: This function expression can be turned into an arrow function. (lint/complexity/useArrowFunction)

Function expressions that don't use this can be turned into arrow functions.
Safe fix: Use an arrow function instead.

Additional comments not posted (3)

tests/pages/settings/profile-page.ts (1)

17-17: Well-implemented hover event for testing.

The addition of the hover event using triggerable('mouseenter') for the refreshFromGitHubButton is correctly implemented and aligns well with the PR's objective to enhance UI testing functionalities.

tests/acceptance/settings-page/profile-test.js (2)

4-4: Correct import for tooltip testing.

The import of assertTooltipContent is necessary and correctly placed for testing the tooltip content in the new functionality.

---

78-83: Well-structured test for tooltip content verification.

The test that simulates hovering over the refreshFromGitHubButton and asserts the tooltip content is well-implemented. It effectively uses the assertTooltipContent function to ensure the tooltip's visibility and content accuracy, aligning with the PR's objectives to maintain tooltip appearance regardless of the button's state.