-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CC-1296 add refresh from github button #1867
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
78ed3bc
feat: Add refresh from github button
libmartinito a61d5db
feat: Add tests for refresh from github button
libmartinito b376304
fix: Lint fix
libmartinito 861ca2b
refactor: Change sync-github-username to sync-username-from-github
libmartinito 9062f2e
fix: Removed unnecessary 'await settled()'
libmartinito 8651f5a
feat: Add guard against being able to refresh github username if user…
libmartinito 0dc7027
fix: Lint fix
libmartinito 9518266
feat: Added tooltip for refresh from github button when anonymous mod…
libmartinito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,24 +11,32 @@ | |
{{#if @user.hasAnonymousModeEnabled}} | ||
<EmberTooltip @text="Your profile has anonymous mode enabled. Your GitHub username is not visible to others." /> | ||
{{else}} | ||
{{! activate this once implemented }} | ||
{{! <EmberTooltip @text="This value is synced with your GitHub account. Click on the refresh button below to update your username." /> }} | ||
<EmberTooltip @text="This value is synced with your GitHub account." /> | ||
<EmberTooltip @text="This value is synced with your GitHub account. Click on the refresh button below to update your username." /> | ||
{{/if}} | ||
</div> | ||
<div class="text-gray-400 text-xs mt-1"> | ||
{{#if @user.hasAnonymousModeEnabled}} | ||
Your profile has anonymous mode enabled. Your GitHub username is not visible to others. | ||
{{else}} | ||
This value is synced with your GitHub account. | ||
This value is synced with your GitHub account. Click on the refresh button below to update your username. | ||
{{/if}} | ||
</div> | ||
|
||
{{!-- TODO: Bring this back once implemented }} | ||
{{!-- <TertiaryButtonWithSpinner @size="extra-small" class="mt-4" @shouldShowSpinner={{false}}> | ||
<TertiaryButtonWithSpinner | ||
@size="extra-small" | ||
class="mt-4" | ||
@shouldShowSpinner={{this.isSyncingUsernameFromGitHub}} | ||
@isDisabled={{this.currentUser.hasAnonymousModeEnabled}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @libmartinito let's add a tooltip when this button is disabled:
|
||
{{on "click" this.refreshFromGitHub}} | ||
data-test-refresh-from-github-button | ||
> | ||
<div class="flex items-center gap-1"> | ||
{{svg-jar "refresh" class="w-4 h-4 text-gray-400"}} | ||
Refresh from GitHub | ||
</div> | ||
</TertiaryButtonWithSpinner> --}} | ||
|
||
{{#if this.currentUser.hasAnonymousModeEnabled}} | ||
<EmberTooltip @text="Your profile has anonymous mode enabled. Your GitHub username is not visible to others." /> | ||
{{/if}} | ||
</TertiaryButtonWithSpinner> | ||
</Settings::FormSection> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a user has anonymous mode enabled, should we show this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a user has anonymous mode enabled and clicked on this, what would happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense. user shouldn't be able to change github username if anonymous