add QueryMetricsExtension to graphql view #572
Conversation
|
|
||
| extension.set_type_and_name(query=sample_wildcard) | ||
| assert extension.operation_type == "unknown_type" | ||
| assert extension.operation_name == "unknown_name" |
There was a problem hiding this comment.
Does anyone know any additional query formats/patterns? LMK
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
+ Coverage 91.40% 91.42% +0.02%
==========================================
Files 604 604
Lines 16052 16102 +50
==========================================
+ Hits 14672 14722 +50
Misses 1380 1380
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #572 +/- ##
==========================================
+ Coverage 91.40% 91.42% +0.02%
==========================================
Files 604 604
Lines 16052 16102 +50
==========================================
+ Hits 14672 14722 +50
Misses 1380 1380
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
=======================================
+ Coverage 95.86 95.87 +0.01
=======================================
Files 782 782
Lines 17370 17420 +50
=======================================
+ Hits 16651 16701 +50
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nora-codecov
force-pushed
the
nora/1238
branch
3 times, most recently
from
48d6ff6
to
4b0a637
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Purpose/Motivation
Gives insight into our GraphQL use
Links to relevant tickets
codecov/engineering-team#1238
What does this PR do?
Adds 2 counters and 1 timer to our GQL endpoint, we should be able to see what queries are being used the most and if any are mad slow
Notes to Reviewer
The hardest part for me was trying to anticipate all the possible formats for our queries, to be able to parse and log them correctly in
set_type_and_name. I have them listed intest_query_metrics_extension_set_type_and_name. If anyone knows of any other patterns we use, let me know and I'll build them in.