Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add isort rules for ruff and fix #571

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

ajay-sentry
Copy link
Contributor

Purpose/Motivation

What is the feature? Why is this being done?

Part of adding more lint rules to API / Shared / Worker -- codecov/engineering-team#1716

This PR simply adds and fixes the "I" rules -- https://docs.astral.sh/ruff/rules/#isort-i

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@ajay-sentry ajay-sentry requested review from a team as code owners May 17, 2024 20:24
@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (18722b4) to head (0b3cffd).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   91.36%   91.35%   -0.01%     
==========================================
  Files         599      599              
  Lines       15974    15972       -2     
==========================================
- Hits        14594    14592       -2     
  Misses       1380     1380              
Flag Coverage Δ
unit 91.35% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 91.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (18722b4) to head (0b3cffd).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   91.36%   91.35%   -0.01%     
==========================================
  Files         599      599              
  Lines       15974    15972       -2     
==========================================
- Hits        14594    14592       -2     
  Misses       1380     1380              
Flag Coverage Δ
unit 91.35% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 91.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/public/v2/compare/views.py 98.11% <100.00%> (ø)
api/shared/permissions.py 98.87% <100.00%> (-0.03%) ⬇️
graphql_api/types/config/config.py 100.00% <100.00%> (ø)
upload/helpers.py 94.56% <ø> (ø)
upload/views/bundle_analysis.py 98.52% <100.00%> (ø)
upload/views/commits.py 100.00% <ø> (ø)
upload/views/empty_upload.py 91.54% <100.00%> (ø)
upload/views/reports.py 100.00% <ø> (ø)
upload/views/upload_completion.py 100.00% <ø> (ø)

Impacted file tree graph

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (18722b4) to head (0b3cffd).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #571   +/-   ##
=====================================
  Coverage   95.84   95.84           
=====================================
  Files        777     777           
  Lines      17292   17290    -2     
=====================================
- Hits       16573   16571    -2     
  Misses       719     719           
Flag Coverage Δ
unit 91.35% <100.00%> (-0.01%) ⬇️
unit-latest-uploader 91.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajay-sentry ajay-sentry added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 7fe50b4 May 20, 2024
21 of 22 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/ruff-add-isort-rules branch May 20, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants