Add update self hosted settings mutation #559
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
=======================================
+ Coverage 95.84 95.86 +0.02
=======================================
Files 779 782 +3
Lines 17320 17370 +50
=======================================
+ Hits 16601 16651 +50
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 91.37% 91.40% +0.02%
==========================================
Files 601 604 +3
Lines 16002 16052 +50
==========================================
+ Hits 14622 14672 +50
Misses 1380 1380
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 91.37% 91.40% +0.02%
==========================================
Files 601 604 +3
Lines 16002 16052 +50
==========================================
+ Hits 14622 14672 +50
Misses 1380 1380
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rohitvinnakota-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
rohitvinnakota-codecov
temporarily deployed
to
staging
GitHub Actions
Inactive
…innakota/migrate-self-hosted-settings
rohitvinnakota-codecov
changed the title
rohitvinnakota-codecov
changed the title
|
|
||
| if not settings.IS_ENTERPRISE: | ||
| raise ValidationError( | ||
| "enable_autoactivation and disable_autoactivation are only available in self-hosted environments" |
There was a problem hiding this comment.
nit: enable_auto_activation vs. enable_autoactivation
There was a problem hiding this comment.
I could see it either way, but because we're camelcasing the input on AutoActivate, it seems more consistent
There was a problem hiding this comment.
these are what the methods are called in self_hosted.py
rohitvinnakota-codecov
deleted the
rvinnakota/migrate-self-hosted-settings
branch
Purpose/Motivation
This PR closes codecov/engineering-team#1473. We want to move our REST endpoints to GQL. This change creates a mutation and adds an additional resolver that will be consumed in gazebo in
useSelfHostedSettingsandAutoActivateMembers(we are currently making aGETandPATCHREST call).A follow up PR will be made in gazebo to migrate the endpoints.
After that, we will delete the old REST code, once we confirm that it is no longer in use.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.