Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Added ability to intercept button clicks to let the user add custom code #50

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

grapescan
Copy link

@andrew-codechimp
Copy link
Member

A nice addition. Can you add example use in the example application and some documentation in the readme file?

@grapescan
Copy link
Author

Done

@EgyptianM
Copy link

It doesn't send user to market when using AppRater.showRateDialog(this); or when dialog show after 3 days and 7 launches after this addition.

And the demo isn't working.

@grapescan
Copy link
Author

Thanks for spotting, @EgyptianM
I've fixed the demo and added warning that callback code runs in background thread.

@EgyptianM
Copy link

Thanks @grapescan for your quick response. I'll check it out.
Have a nice day
Regards

@EgyptianM
Copy link

If I didn't Override onRateClick or onLaterClick it doesn't handle them as default action is sending user to the market.

Can you make the default action is sending user to the market without Overriding?

@grapescan
Copy link
Author

Fixed that.

@EgyptianM
Copy link

Thanks a lot 👍

@mehrrizwan
Copy link

hi @andrew-codechimp, when are you planning to merge this pull request?

@andrew-codechimp
Copy link
Member

Other than translations I do not intend to add any other functionality to the library at this time.
I simply don't have enough time to thoroughly regression test any new functionality.
I suggest you take your own fork and work with that.

Dmitrii Soldatov and others added 2 commits October 5, 2020 15:39
… version to be up-to-date with modern requirements.
Updated versions of Gradle plugin, build tools and target Android SDK…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants