Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

New feature significative event counter #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Narfss
Copy link

@Narfss Narfss commented Jan 14, 2015

Prompting can be showed after some user significant interaction.

New counter SIGNIFICANT_EVENT and parameter in constructor.

Function userDidSignificantEvent increase the events counter and show rate promp.

*/
public static void app_launched(Context context, int daysUntilPrompt, int launchesUntilPrompt, int daysForRemind, int launchesForRemind) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing methods with the additional parameters will break existing implementations that use this particular calling method. It would be better to implement your own additional overloaded methods though I'm worried about telescoping this too far and getting a very messy implementation (more than it is today)
Commenting on just this one but there are further breaking overloads.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it
At this point, the better choice is change all to pattern builder.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, it would break existing compatibility but with yours and other feature requests it makes sense.

Unfortunately I don't have time to do this immediately and so will not only be maintaining current features for now but will start a new branch for a V2 in future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants