Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where updateRecord returns network response rather than record object #57136

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

cnbrenci
Copy link
Contributor

@cnbrenci cnbrenci commented Mar 8, 2024

Fixed bug where updateRecord was returning the network response rather than the record object.

@cnbrenci cnbrenci changed the title Parse the JSON response isntead of returning it :) Fix bug where updateRecord returns network response rather than record object Mar 8, 2024
@cnbrenci cnbrenci requested a review from snickell March 8, 2024 01:29
Copy link
Contributor

@snickell snickell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@snickell
Copy link
Contributor

snickell commented Mar 8, 2024

Fixes #56759

@cnbrenci cnbrenci merged commit 1a0f06c into unfirebase Mar 8, 2024
@cnbrenci cnbrenci deleted the datablock/fix-update-record-response branch March 8, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants