Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core.js stop injecting junk into HTML element on load #2197

Closed
wants to merge 4 commits into from

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Apr 21, 2024

only settings used by CSS allowed

@ImprovedTube
Copy link
Member

So it is the category appearance yet (next to much of general & others.) & given it is many, we could equally skip what we predict to never need😅) Related: #2193 & #1935this old thing to say

blocking.

Should be done before youtube's response is there 💭

@ImprovedTube
Copy link
Member

how many ms does writing the attributes to the <html> root element run and how many does it delay the rest?

@raszpl
Copy link
Contributor Author

raszpl commented Apr 27, 2024

I would say zero speed difference :) Its my military grade autism not liking all the config variables being stuffed into html tag, like why is it trying to fit blocklist in there? makes debugging annoying with half of devtools page filled with just html tag.

@ImprovedTube
Copy link
Member

ImprovedTube commented Apr 27, 2024

if so, we might benchmark,
(or go with excluding only? to make sure none is missing and future ones exist in css)

(since codecs might runs soon enough already from the earlier storage-loaded event alone)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants