Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use array pool instead of shared array #16988

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

minggo
Copy link
Contributor

@minggo minggo commented May 14, 2024

shared array will have problem if dispatching an event in a event call back function and the event type is propagationStopped

Re: #16914

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@minggo
Copy link
Contributor Author

minggo commented May 14, 2024

@cocos-robot run test cases

Copy link

Interface Check Report

This pull request does not change any public interfaces !

@sushanhong
Copy link

@cocos-robot run test cases

9 similar comments
@sushanhong
Copy link

@cocos-robot run test cases

@sushanhong
Copy link

@cocos-robot run test cases

@sushanhong
Copy link

@cocos-robot run test cases

@sushanhong
Copy link

@cocos-robot run test cases

@sushanhong
Copy link

@cocos-robot run test cases

@sushanhong
Copy link

@cocos-robot run test cases

@sushanhong
Copy link

@cocos-robot run test cases

@sushanhong
Copy link

@cocos-robot run test cases

@sushanhong
Copy link

@cocos-robot run test cases

shared array will have problem if dispatching and event in a event call back function and the event type is propagationStopped
@minggo
Copy link
Contributor Author

minggo commented May 21, 2024

@cocos-robot run test cases

Copy link

@minggo, Please check the result of run test cases:

Task Details

Copy link

@minggo, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL capture_to_web,cameraUseRenderTex,use-render-texture-asset
android PASS PASS PASS

@minggo minggo merged commit e7620a3 into cocos:v3.8.5 May 21, 2024
9 checks passed
@minggo minggo deleted the dispatch-event-issue branch May 21, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants