Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overcome download connection errors #389

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

giladgd
Copy link

@giladgd giladgd commented Apr 12, 2023

  • Switched from axios to easydl library for downloading files since easydl overcomes connection errors better and also supports multithreaded downloads, significantly improving the download speed.
  • Added support for downloading files in parallel to improve download speeds

Screenshot 2023-04-12 at 18 31 22

In the meantime, you can install this version of dalai by running this command:

npm install -g "github:giladgd/dalai#overcomeDownloadConnectionErrors"

@fredroo
Copy link

fredroo commented Apr 18, 2023

@cocktailpeanut take a look on this PR, this is a solution for download stopped

@fredroo
Copy link

fredroo commented Apr 18, 2023

@giladgd
I clone your repository and changed Dockerfile on this line
Change this line:
RUN npm install [email protected]
To:
RUN npm install "https://github.com/giladgd/dalai#overcomeDownloadConnectionErrors"

solved any problems with download stopped

@fredroo
Copy link

fredroo commented Apr 18, 2023

@giladgd but show this error
(node:18) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [WriteStr
eam]. Use emitter.setMaxListeners() to increase limit

@DreamOfEternalHappiness

It might be for that possible memory leak, but my download never gets 100% while using that dalai from:

npm install "https://github.com/giladgd/dalai#overcomeDownloadConnectionErrors"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants