-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authors: add annaw2193 to authors #124145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is good. A few comments on the PR body and commit message.
- The
Release Note
line should be last in the commit message. The parser for them is greedy and takes everything after it as part of the release note. Could you update the commit message to place it last? The Updating PRs during review page discusses how to do this. - Did one of the linters ask for the
Release justification
line in the PR description? That should only be needed for backport PRs.
Also, this PR looks ready to be moved out of Draft mode. Normally, we used draft mode here to indicate that a PR isn't ready for review yet.
Epic: None Release note: None
b67f53e
to
d58a84b
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
The ordering of the release note line was based on the document provided for the first PR, should I update this document with the Release note line last in the commit message instead to reflect this?
Ah. I see. These guides are updateable. How about putting in a change suggestion on that doc to correct the ordering?
sounds good! I've made some suggestions in the doc to reflect this |
bors r+ |
Epic: None
Release note: None