Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: roachprod: bump max DNS results limit #124117

Merged

Conversation

herkolategan
Copy link
Collaborator

@herkolategan herkolategan commented May 14, 2024

Backport 1/1 commits from #121047.

/cc @cockroachdb/release


The gcloud DNS commands filter after retrieving results, set by the limit, and not before, since the API call itself has no concept of a filter. This means the limit has to be higher to ensure the full list is retrieved, before the gcloud command filters. Currently, we are getting nearer to the 1000 limit, hence this change bumps it to 10000 to avoid possible future problems.

Epic: None
Release Note: None

Release justification: Test only change.

The `gcloud` DNS commands filter after retrieving results, set by the limit, and
not before, since the API call itself has no concept of a filter. Currently, we
are getting nearer to the 1000 limit, hence this change bumps it to 10000 to
avoid possible future problems.

Epic: None
Release Note: None
Copy link

blathers-crl bot commented May 14, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label May 14, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@herkolategan herkolategan marked this pull request as ready for review May 14, 2024 11:05
@herkolategan herkolategan requested a review from a team as a code owner May 14, 2024 11:05
@herkolategan herkolategan requested review from nameisbhaskar and vidit-bhat and removed request for a team May 14, 2024 11:05
@srosenberg srosenberg self-requested a review May 14, 2024 16:21
@herkolategan herkolategan merged commit 4b3b0ea into cockroachdb:release-23.1 May 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants