roachprod: fetch secrets from cloud store #124099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameisbhaskar
requested review from
srosenberg and
vidit-bhat
and removed request for
a team
|
This change is |
nameisbhaskar
force-pushed
the
user/bhaskar/use-store-secrets
branch
12 times, most recently
from
988c747
to
9587ca8
Compare
srosenberg
approved these changes
May 15, 2024
|
Thanks Stan for reviewing this! |
Due to the complexity of fetching the secrets from the secrets manager, the secrets are now maintained in cloud storage. Fixes: cockroachdb#117125 Epic: none
nameisbhaskar
force-pushed
the
user/bhaskar/use-store-secrets
branch
from
9587ca8
to
473f257
Compare
|
bors r=@srosenberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the complexity of fetching the secrets from the secrets manager, the secrets are now maintained in cloud storage.
Fixes: #117125
Epic: none