ConsoleInteraction: Replace nothing_done() inline

[PrasanthChettri]

Fixes #4523
Removed occurrences of nothing done method in ConsoleInteraction and
Accommodated the code with consequent code changes, eg : deleted tests for the method

---

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

• I read the commit guidelines and I've followed
  them.
• I ran coala over my code locally. (All commits have to pass
  individually. It is not sufficient to have "fixup commits" on your PR,
  our bot will still report the issues for the previous commit.) You will
  likely receive a lot of bot comments and build failures if coala does not
  pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

• pick up any PR at https://coala.io/review
• review it (check https://coala.io/reviewing for more info)
• if you are sure that it needs work, use corobo mark wip <URL> to get it out
  of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

[PrasanthChettri]

@anshalshukla I cannot figure out why the tests are failing, if it's not much trouble could you help me with this

[anshalshukla]

Yeah Sure!
The CI is failing with error:

**** GitCommitBear [Section: commit | Severity: NORMAL] ****
!    ! Shortlog of HEAD commit isn't in imperative mood! Bad words are 'fixed'

You can update the commit message and check if the bears pass the test using coala --non-interactive locally.

[akshatkarani]

Squash your commits and follow the commit guidelines

[PrasanthChettri]

Additionally coalib/coala_main/run_coala() has these default arguments of do_nothing() that just returns True, one could just have an inline definition such as

print_results = lambda *args : True

which would remove one more indirection, I don't know if it's good code practice or not, would love to have some feedback on this

[akshatkarani]

Since you are removing the parameter nothing_done, default do_nothing is no longer needed. You can remove it

It is used as default value for other parameter, keep it. Also it is better to keep it as a function because it is used more than once

[PrasanthChettri]

Since you are removing the parameter nothing_done, default do_nothing is no longer needed. You can remove it

It is used as default value for other parameter, keep it. Also it is better to keep it as a function because it is used more than once

@akshatkarani, @anshalshukla Okay,thanks for the suggestion, the commits do not have the changes and I think are good to go for a review

[akshatkarani]

LGTM

[abhishalya]

The issue is not a bug, so the commit short log should mention it Closes the issue. Everything else lgtm.

[PrasanthChettri]

The issue is not a bug, so the commit short log should mention it Closes the issue. Everything else lgtm.

Done
@abhishalya Can it be merged now ?

[utkarsh2102]

Me likey! +1! 🌮