ConfigurationGathering.py: modify get_config_directory docstring #5882
Conversation
There was a problem hiding this comment.
Commit message should follow coala's guideline.
https://coala.io/newcomer
Also, you need to rebase.
There was a problem hiding this comment.
Commit is not following guidelines
https://coala.io/newcomer
There was a problem hiding this comment.
Please follow the commit guidelines given in http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html
|
okay will do |
Changed multiple double quotes to single quotes in get_config_directory docstring Fixes coala#5858
…hriram98/coala into get_config_directory_docstring
gitmate-bot
added
process/pending review
area/aspects
area/documentation
and removed
process/wip
labels
shriram98
changed the title
|
Comment on fcf742c. Shortlog of the HEAD commit contains 119 character(s). This is 69 character(s) longer than the limit (119 > 50). Origin: GitCommitBear, Section: |
|
Comment on fcf742c. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+[^ ]: [A-Z0-9].*) Origin: GitCommitBear, Section: |
|
Comment on 3ea380a. Shortlog of the HEAD commit contains 64 character(s). This is 14 character(s) longer than the limit (64 > 50). Origin: GitCommitBear, Section: |
|
And I think you should take a look on travis fail and solve problems 😉 |
There was a problem hiding this comment.
- You may want to
amendthe commit message as per the guidelines. - Once done, you will need to rebase it. Refer this.
- Also, read the Newcomer's Guide, if you haven't.
- Additionally, always make the CI green and happy ;)
|
Okay I am working on it |
There was a problem hiding this comment.
Please rebase before making a PR.
😉
Also, in your commit message, you need to change Fixes to Closes.
Read Writing good commits.
There was a problem hiding this comment.
Please rebase all the commits into one
Squash the commits into one..
Refer to this link https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
Can be helpful
|
Hi, @RJ722 |
|
Oops, looks like I assigned over at the wrong place! |
|
This should be closed as #6073 has been approved |
Changed multiple double quotes to single quotes in get_config_directory docstring
Fixes #5858