Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal of Kubespray project for LFX 2024 Jun-Aug #1247

Merged
merged 2 commits into from
May 15, 2024
Merged

Proposal of Kubespray project for LFX 2024 Jun-Aug #1247

merged 2 commits into from
May 15, 2024

Conversation

yankay
Copy link
Contributor

@yankay yankay commented May 14, 2024

@yankay yankay force-pushed the add-kubespray branch 2 times, most recently from ec22fdd to 6eae89b Compare May 14, 2024 07:06
@MadhavJivrajani
Copy link

Explicit +1 from me

with my SIG ContribEx hat on.

@palnabarun
Copy link

palnabarun commented May 14, 2024 •
edited

Explicit +1 with the SIG ContribEx hat on.

nate-double-u
nate-double-u reviewed May 14, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this @yankay!

I have a couple comments in line :)

programs/lfx-mentorship/2024/02-Jun-Aug/README.md Outdated

#### Bug fix and enhancement of the helm support for add-ons.

- Description: Kubespray is a sig project of kubernetes. It helps deploy a production-ready Kubernetes cluster with ansible. The project Kubespray wants maintainers to help fix the bug and enhance the new features. https://github.com/kubernetes-sigs/kubespray/issues/5432.The project's journey will start with tackling some 'help wanted' issues related to bug fixes and documentation. This initial involvement will help the mentee understand the Kubespray implementation and pave the way for potential maintainership.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a URL in the middle of this paragraph that looks out of place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nate-double-u
It has been changed :-)

programs/lfx-mentorship/2024/02-Jun-Aug/README.md Outdated
- Expected Outcome: Bug fix and enhancement of the helm support for add-ons.
- Recommended Skills: Ansible, Kubernetes
- Mentor(s):
- Kay Yan (yankay, <[email protected]>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer to have at least 2 mentors -- are you able to recruit another person to co-mentor with you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @nate-double-u

@mzaian will join as another mentor :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @yankay & @mzaian!

@yankay yankay force-pushed the add-kubespray branch 2 times, most recently from 8caf20b to 05aee33 Compare May 15, 2024 07:27
nate-double-u
nate-double-u requested changes May 15, 2024
View reviewed changes
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should target programs/lfx-mentorship/2024/02-Jun-Aug/project_ideas.md, part of our process is moving from project ideas to the README as the LFX approves the project.

I can make this change myself, but I wanted to let you know I'll be moving it shortly.

@yankay @nate-double-u
add Kubespray
417017b 
Signed-off-by: Kay Yan <[email protected]>
@nate-double-u
Copy link
Member

Oh wait, this has already been setup on LFX earlier. I think we may be best to create a new one to keep things in line with the way we run the other projects. CNCF Mentorshipadmins will own the project, and I'll invite @yankay and @mzaian as mentors.

@nate-double-u nate-double-u merged commit 4863bd4 into cncf:main May 15, 2024
2 checks passed
@yankay
Copy link
Contributor Author

yankay commented May 16, 2024

@nate-double-u
Thank you 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u approved these changes

Assignees
No one assigned
Labels
2024 lfx mentorship Term 2: June-Aug
Projects
TAG Contributor Strategy Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yankay @MadhavJivrajani @palnabarun @nate-double-u