Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generic): support grpc json generic for client #1411

Open
wants to merge 51 commits into
base: release-v0.11.0
Choose a base branch
from

Conversation

Marina-Sakai
Copy link
Contributor

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@Marina-Sakai Marina-Sakai requested review from a team as code owners June 24, 2024 05:44
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 31.92982% with 194 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-v0.11.0@7832739). Learn more about missing BASE report.

Current head b84656f differs from pull request most recent head 7b98b9b

Please upload reports for the commit 7b98b9b to get more accurate results.

Files Patch % Lines
client/genericclient/stream.go 0.00% 107 Missing ⚠️
server/genericserver/stream.go 0.00% 28 Missing ⚠️
pkg/generic/generic_stream_service.go 0.00% 24 Missing ⚠️
pkg/generic/grpcjsonpb_test/generic_init.go 78.20% 10 Missing and 7 partials ⚠️
pkg/remote/codec/grpc/grpc.go 0.00% 15 Missing ⚠️
pkg/generic/thrift/parse.go 86.66% 1 Missing and 1 partial ⚠️
pkg/generic/httppbthrift_codec.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release-v0.11.0    #1411   +/-   ##
==================================================
  Coverage                   ?   69.75%           
==================================================
  Files                      ?      300           
  Lines                      ?    21505           
  Branches                   ?        0           
==================================================
  Hits                       ?    15000           
  Misses                     ?     5274           
  Partials                   ?     1231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


methods := map[string]serviceinfo.MethodInfo{
serviceinfo.GenericClientStreamingMethod: serviceinfo.NewMethodInfo(
nil,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: stream serviceInfo for server side will requires to import genericserver package, which will lead cyclic import. So need to handle it when supporting server side grpc generic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better to define client stream serviceInfo and server stream serviceInfo separately in genericclient/genericserver package.

Copy link
Member

@jayantxie jayantxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants