-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(generic): support grpc json generic for client #1411
base: release-v0.11.0
Are you sure you want to change the base?
feat(generic): support grpc json generic for client #1411
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v0.11.0 #1411 +/- ##
==================================================
Coverage ? 69.75%
==================================================
Files ? 300
Lines ? 21505
Branches ? 0
==================================================
Hits ? 15000
Misses ? 5274
Partials ? 1231 ☔ View full report in Codecov by Sentry. |
|
||
methods := map[string]serviceinfo.MethodInfo{ | ||
serviceinfo.GenericClientStreamingMethod: serviceinfo.NewMethodInfo( | ||
nil, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: stream serviceInfo for server side will requires to import genericserver package, which will lead cyclic import. So need to handle it when supporting server side grpc generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be better to define client stream serviceInfo and server stream serviceInfo separately in genericclient/genericserver package.
…which has the generic's reader and writer info directly (cloudwego#1365)
16a8829
to
cbae570
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: