Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codec): add option to enable span cache and disable it by default #1410

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

joway
Copy link
Member

@joway joway commented Jun 24, 2024

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix(codec): 添加 option 开启 span cache,默认关闭

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@joway joway requested review from a team as code owners June 24, 2024 03:44
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 51.25000% with 195 lines in your changes missing coverage. Please review.

Project coverage is 70.29%. Comparing base (ff5ca14) to head (658e8de).
Report is 60 commits behind head on main.

Current head 658e8de differs from pull request most recent head e541ee2

Please upload reports for the commit e541ee2 to get more accurate results.

Files Patch % Lines
pkg/generic/thrift/json.go 0.00% 35 Missing ⚠️
pkg/generic/httppbthrift_codec.go 16.66% 25 Missing ⚠️
pkg/generic/generic_service.go 55.10% 18 Missing and 4 partials ⚠️
pkg/generic/thrift/json_go116plus_amd64.go 0.00% 19 Missing ⚠️
pkg/generic/mapthrift_codec.go 68.29% 11 Missing and 2 partials ⚠️
pkg/generic/jsonthrift_codec.go 66.66% 10 Missing and 2 partials ⚠️
pkg/generic/generic.go 71.42% 10 Missing ⚠️
pkg/generic/jsonpb_codec.go 56.52% 8 Missing and 2 partials ⚠️
pkg/generic/httpthrift_codec.go 70.96% 8 Missing and 1 partial ⚠️
pkg/generic/thrift/http_go116plus_amd64.go 12.50% 7 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
+ Coverage   70.13%   70.29%   +0.15%     
==========================================
  Files         289      293       +4     
  Lines       20874    21177     +303     
==========================================
+ Hits        14641    14886     +245     
- Misses       5025     5065      +40     
- Partials     1208     1226      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

YangruiEmma
YangruiEmma previously approved these changes Jun 24, 2024
@joway joway changed the base branch from develop to main June 24, 2024 06:12
@joway joway dismissed YangruiEmma’s stale review June 24, 2024 06:12

The base branch was changed.

@joway joway force-pushed the feat/cntr-mem branch 4 times, most recently from 693f15b to 38fcbbc Compare June 24, 2024 07:39
@joway joway changed the title fix(codec): control span cache memory usage to avoid some long-live fields hold too many memory fix(codec): add option to enable span cache and disable it by default Jun 24, 2024
@joway joway merged commit 136cc3a into cloudwego:main Jun 24, 2024
20 checks passed
@joway joway deleted the feat/cntr-mem branch June 24, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants