Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo and code style #1341

Closed
wants to merge 3 commits into from
Closed

fix: typo and code style #1341

wants to merge 3 commits into from

Conversation

hakusai22
Copy link

@hakusai22 hakusai22 commented Apr 25, 2024 •
edited

What type of PR is this?

  • typo.
  • code style.

@hakusai22 hakusai22 requested review from a team as code owners April 25, 2024 06:25
@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

Marina-Sakai
Marina-Sakai previously approved these changes Apr 25, 2024
View reviewed changes
Marina-Sakai
Marina-Sakai reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@Marina-Sakai Marina-Sakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try gofumpt -w client/rpctimeout_test.go to make the CI link test pass

@hakusai22
Copy link
Author

hakusai22 commented Apr 25, 2024 •
edited

Please try gofumpt -w client/rpctimeout_test.go to make the CI link test pass

Hello, I haven't made any changes to the ast.go and patcher.go files. Their code styles don't match. I have made some modifications here. Could you please help me pass the tests again.

image image

According to the submission time, the code style submitted by Duan yesterday has already failed the test. #1336
image

@hakusai22
Copy link
Author

hakusai22 commented Apr 30, 2024 •
edited

Please try gofumpt -w client/rpctimeout_test.go to make the CI link test pass

@Marina-Sakai hello, Can you help me review it again?

@hakusai22 hakusai22 changed the title fix: typo fix: typo and code style Apr 30, 2024
@GuangmingLuo
Copy link
Member

Thank you for your attention and suggestion to this project. Meaningful PRs are always welcome. Please try use some tools to help to add as much typos fix or other optimizations as possible in one PR. A PR with only one typo fixing is less meaningful.

@hakusai22 hakusai22 closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marina-Sakai Marina-Sakai Marina-Sakai approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hakusai22 @CLAassistant @GuangmingLuo @Marina-Sakai