chore: resolve syntax/spelling/format errors prompted by inspect code tool #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete extra spaces
3 tasks
DMwangnima
reviewed
Apr 22, 2024
| @@ -19,7 +19,7 @@ package test | |||
| import ( | |||
| "bytes" | |||
| "context" | |||
| "io/ioutil" | |||
| "io" | |||
There was a problem hiding this comment.
We use ioutil.ReadAll for compatibility since kitex go module version is 1.13.
| @@ -269,7 +269,7 @@ func (b *defaultByteBuffer) AppendBuffer(buf ByteBuffer) (err error) { | |||
| return | |||
| } | |||
|
|
|||
| // Bytes is used to get the bytes written. | |||
| // Bytes are used to get the bytes written. | |||
There was a problem hiding this comment.
Bytes is function name so that "is" makes more sense.
| @@ -142,7 +142,7 @@ func (a *Arguments) buildFlags(version string) *flag.FlagSet { | |||
| e.Apply(f) | |||
| } | |||
| f.Usage = func() { | |||
| fmt.Fprintf(os.Stderr, `Version %s | |||
| _, _ = fmt.Fprintf(os.Stderr, `Version %s | |||
There was a problem hiding this comment.
This belongs to the code style issue. if the linter doesn't report errors, it doesn't need to be modified
| @@ -102,7 +101,7 @@ NormalExit: | |||
|
|
|||
| func DeleteKitexYaml() { | |||
| // try to read kitex.yaml | |||
| data, err := ioutil.ReadFile("kitex.yaml") | |||
| data, err := os.ReadFile("kitex.yaml") | |||
| @@ -515,7 +514,7 @@ func (c *converter) persist(res *plugin.Response) error { | |||
| if err := os.MkdirAll(path, 0o755); err != nil && !os.IsExist(err) { | |||
| return fmt.Errorf("failed to create path '%s': %w", path, err) | |||
| } | |||
| if err := ioutil.WriteFile(full, content, 0o644); err != nil { | |||
| if err := os.WriteFile(full, content, 0o644); err != nil { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
it's a chore pr.
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: