feat(client): prioritize BizStatusError in DefaultClientErrorHandler #1253
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWhiteWu
force-pushed
the
feat/prioritize_biz_status_error
branch
2 times, most recently
from
bc5ccd8
to
480dac3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1253 +/- ##
===========================================
+ Coverage 68.46% 68.50% +0.03%
===========================================
Files 285 285
Lines 20708 20712 +4
===========================================
+ Hits 14178 14188 +10
+ Misses 5336 5332 -4
+ Partials 1194 1192 -2 ☔ View full report in Codecov by Sentry. |
PureWhiteWu
force-pushed
the
feat/prioritize_biz_status_error
branch
from
480dac3
to
b088062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the PR title.
(Optional) Translate the PR title into Chinese.
如果 BizStatusError 存在，优先返回 BizStatusError。
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: If BizStatusError is not nil, it means that the business logic has been processed and the error has been set and transmitted to the client. In this case, just return the bizErr directly.
zh(optional): 如果 BizStatusError 存在，那么必然是 Server 返回回来的，这时可以直接返回这个 BizStatusError。