perf: nocopy read binary

cloudwego · May 24, 2024 · 36515e4 · 36515e4
1 parent a9249d4
commit 36515e4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/pkg/protocol/bthrift/binary.go b/pkg/protocol/bthrift/binary.go
@@ -467,8 +467,7 @@ func (binaryProtocol) ReadString(buf []byte) (value string, length int, err erro
  if size < 0 || int(size) > len(buf) {
  return value, length, perrors.NewProtocolErrorWithType(thrift.INVALID_DATA, "[ReadString] the string size greater than buf length")
  }
- data := spanCache.Copy(buf[length : length+int(size)])
- value = utils.SliceByteToString(data)
+ value = utils.SliceByteToString(buf[length : length+int(size)])
  length += int(size)
  return
 }
@@ -484,7 +483,7 @@ func (binaryProtocol) ReadBinary(buf []byte) (value []byte, length int, err erro
  if size < 0 || size > len(buf) {
  return value, length, perrors.NewProtocolErrorWithType(thrift.INVALID_DATA, "[ReadBinary] the binary size greater than buf length")
  }
- value = spanCache.Copy(buf[length : length+size])
+ value = buf[length : length+size]
  length += size
  return
 }

diff --git a/pkg/remote/codec/thrift/binary_protocol.go b/pkg/remote/codec/thrift/binary_protocol.go
@@ -509,7 +509,7 @@ func (p *BinaryProtocol) ByteBuffer() remote.ByteBuffer {
 
 // next ...
 func (p *BinaryProtocol) next(size int) ([]byte, error) {
- buf, err := p.trans.Next(size)
+ buf, err := p.trans.ReadBinary(size)
  if err != nil {
  return buf, perrors.NewProtocolError(err)
  }