Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add test connection #1682

Merged
merged 14 commits into from
May 20, 2024
Merged

Conversation

disq
Copy link
Member

@disq disq commented May 15, 2024

Implements explicit test connection feature.

@github-actions github-actions bot added the feat label May 15, 2024
plugin/plugin_testconn.go Outdated Show resolved Hide resolved
plugin/plugin_testconn.go Outdated Show resolved Hide resolved
@disq disq requested a review from mnorbury May 15, 2024 16:11
plugin/options.go Show resolved Hide resolved
Copy link

github-actions bot commented May 16, 2024

⏱️ Benchmark results

  • Glob-8 ns/op: 90.97

@disq disq marked this pull request as ready for review May 16, 2024 13:27
@github-actions github-actions bot added feat and removed feat labels May 16, 2024
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments/questions

plugin/options.go Show resolved Hide resolved
plugin/plugin_testconn.go Show resolved Hide resolved
Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a read through and it looks good to me, though I haven't read the CLI parts yet

examples/simple_plugin/go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@github-actions github-actions bot added feat and removed feat labels May 17, 2024
@disq disq added the automerge label May 20, 2024
@kodiakhq kodiakhq bot merged commit 03493f5 into cloudquery:main May 20, 2024
7 checks passed
kodiakhq bot pushed a commit that referenced this pull request May 20, 2024
🤖 I have created a release *beep* *boop*
---


## [4.43.0](v4.42.2...v4.43.0) (2024-05-20)


### Features

* Add test connection ([#1682](#1682)) ([03493f5](03493f5))


### Bug Fixes

* **deps:** Update module github.com/apache/arrow/go/v16 to v16.1.0 ([#1693](#1693)) ([461e352](461e352))
* **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.11.2 ([#1687](#1687)) ([30b52f7](30b52f7))
* **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.19.13 ([#1690](#1690)) ([c35be5d](c35be5d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@disq disq deleted the feat/add-test-connection branch May 20, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants