Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Batch resources into a single record on source side #1642

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

feat: Batch resources into a single record on source side #1642

wants to merge 43 commits into from
+776 −138

Conversation

candiduslynx
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the test label Apr 22, 2024
@candiduslynx candiduslynx mentioned this pull request Apr 22, 2024
Open
1 task
disq
disq reviewed Apr 22, 2024
View reviewed changes
scheduler/batch.go Outdated Show resolved Hide resolved
disq
disq reviewed Apr 22, 2024
View reviewed changes
scheduler/batch.go Outdated Show resolved Hide resolved
disq
disq reviewed Apr 22, 2024
View reviewed changes
scheduler/batch.go Outdated Show resolved Hide resolved
@candiduslynx candiduslynx requested a review from disq April 22, 2024 12:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2024 •
edited

⏱️ Benchmark results

Comparing with f2e1766

  • Glob-8 ns/op: 91.69 ⬆️ 0.56% increase vs. f2e1766

disq
disq approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs a better PR title

@candiduslynx candiduslynx marked this pull request as ready for review June 6, 2024 07:11
@candiduslynx candiduslynx changed the title test: Experiment with simple worker feat: Batch records on source side Jun 6, 2024
@candiduslynx candiduslynx changed the title feat: Batch records on source side feat: Batch resources into a single record on source side Jun 6, 2024
@github-actions github-actions bot added feat and removed test feat labels Jun 6, 2024
murarustefaan
murarustefaan reviewed Jun 6, 2024
View reviewed changes
scalar/inet.go Show resolved Hide resolved
scalar/time.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disq disq disq approved these changes

@murarustefaan murarustefaan murarustefaan left review comments

@yevgenypats yevgenypats Awaiting requested review from yevgenypats yevgenypats is a code owner

@hermanschaaf hermanschaaf Awaiting requested review from hermanschaaf hermanschaaf is a code owner

@erezrokah erezrokah Awaiting requested review from erezrokah erezrokah is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@candiduslynx @disq @murarustefaan