feat!: Store timestamps as timestamp_tz
#17843
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbernays
requested review from
savme and
hermanschaaf
and removed request for
a team
bbernays
changed the title
timestamp_tztimestamp_tz
|
@bbernays Tests are failing on this PR, just FYI |
|
The tests are failing because of issues with timezone comparison... In my local machine if I add |
erezrokah
reviewed
May 6, 2024
erezrokah
approved these changes
May 6, 2024
disq
approved these changes
May 7, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.0](plugins-destination-snowflake-v3.6.2...plugins-destination-snowflake-v4.0.0) (2024-05-13) ### ⚠ BREAKING CHANGES * Store timestamps as `timestamp_tz` ([#17843](#17843)) ### Features * Store timestamps as `timestamp_tz` ([#17843](#17843)) ([6eb8711](6eb8711)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.41.0 ([#17917](#17917)) ([81f2506](81f2506)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.41.1 ([#17941](#17941)) ([b112a67](b112a67)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.42.0 ([#17951](#17951)) ([f5befb1](f5befb1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we are storing all timestamps as
timestamp_ntzthis is "wall clock" time meaning that it has no timezone associated with it. thearrow.TimestampTypeis:Which makes it a better fit for users to be able to utilize the data in their queries.