Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use global registry env variables #4538

Merged
merged 3 commits into from
May 30, 2024
Merged

ci: use global registry env variables #4538

merged 3 commits into from
May 30, 2024

Conversation

NiccoloFei
Copy link
Collaborator

Let's use the globally instantiated env variables when possible instead of hardcoding the values.

@NiccoloFei NiccoloFei requested a review from a team as a code owner May 15, 2024 12:31
@github-actions github-actions bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.21 release-1.22 release-1.23 labels May 15, 2024
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@NiccoloFei NiccoloFei force-pushed the dev/fix-ci-vars branch 2 times, most recently from e0231f0 to 84e7730 Compare May 15, 2024 13:54
@sxd
Copy link
Member

sxd commented May 15, 2024

/test limit=local depth=push test_level=1 feature_type=basic

Copy link
Contributor

@sxd, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/9099736679

@NiccoloFei NiccoloFei force-pushed the dev/fix-ci-vars branch 4 times, most recently from 756124e to 5a2e9c8 Compare May 28, 2024 09:47
@litaocdl
Copy link
Collaborator

/ok-to-merge

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label May 30, 2024
@gbartolini gbartolini merged commit f0e3fdb into main May 30, 2024
27 of 28 checks passed
@gbartolini gbartolini deleted the dev/fix-ci-vars branch May 30, 2024 09:11
cnpg-bot pushed a commit that referenced this pull request May 30, 2024
Use the globally instantiated env variables when possible,
instead of hardcoding the values.

Signed-off-by: Niccolò Fei <[email protected]>
Signed-off-by: Tao Li <[email protected]>
Co-authored-by: Tao Li <[email protected]>
(cherry picked from commit f0e3fdb)
cnpg-bot pushed a commit that referenced this pull request May 30, 2024
Use the globally instantiated env variables when possible,
instead of hardcoding the values.

Signed-off-by: Niccolò Fei <[email protected]>
Signed-off-by: Tao Li <[email protected]>
Co-authored-by: Tao Li <[email protected]>
(cherry picked from commit f0e3fdb)
cnpg-bot pushed a commit that referenced this pull request May 30, 2024
Use the globally instantiated env variables when possible,
instead of hardcoding the values.

Signed-off-by: Niccolò Fei <[email protected]>
Signed-off-by: Tao Li <[email protected]>
Co-authored-by: Tao Li <[email protected]>
(cherry picked from commit f0e3fdb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-requested ◀️ This pull request should be backported to all supported releases no-issue ok to merge 👌 This PR can be merged release-1.21 release-1.22 release-1.23
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants