qlog: Update ConnectionClose with CryptoError #1734
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the qlog crate fit the specification laid out in quicwg/qlog#392.
This yields the following
ConnectionClose
frame:We won't be able to log
CryptoError
s without a larger change that pushes detection of connection establishment into the qlog crate. We could also explore logging one of two differentConnectionClose
events on close, one each for pre- and post-establishment, but that seemed messy. I can implement that if we do want to go down that route.