Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cloudflared: fix dropped error #1123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmd/cloudflared: fix dropped error #1123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/cloudflared/service_template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,9 @@ func openFile(path string, create bool) (file *os.File, exists bool, err error)
if err != nil {
return nil, false, err
}
var fileInfo os.FileInfo
if create {
fileInfo, err := os.Stat(expandedPath)
fileInfo, err = os.Stat(expandedPath)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch, but we need to check if this returns an error and return it, otherwise line 133 will override the error.

if err == nil && fileInfo.Size() > 0 {
return nil, true, nil
}
Expand Down