Refactor Integration tests #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabi200123
force-pushed
the
integration-tests
branch
3 times, most recently
from
445fd43
to
ed988e9
Compare
test/integration/credentials_test.go
Outdated
| t.Log("Testing error on duplicate credentials name") | ||
| creds, err := suite.createDummyCredentials(dummyCredentialsName, defaultEndpointName) | ||
| suite.NoError(err) | ||
| defer suite.DeleteGithubCredential(int64(creds.ID)) |
There was a problem hiding this comment.
The golang testing package has a Cleanup() function
There was a problem hiding this comment.
Updated all suite to use t.Cleanup instead of defer FunctionName
fabi200123
force-pushed
the
integration-tests
branch
2 times, most recently
from
88f8f49
to
2bec645
Compare
fabi200123
force-pushed
the
integration-tests
branch
from
2bec645
to
9d4c0a9
Compare
gabriel-samfira
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testify/suite