Dont run append if @followers is empty #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorerlingsson
requested review from
carlhoerberg,
kickster97,
snichme and
spuun
as code owners
spuun
approved these changes
May 24, 2024
|
this introduced a bug, if a follower is currently syncing the publish is not blocked (as before this PR), and can cause data loss at the follower |
same could be added to all actions, but |
Ah, yes. Reverted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
Replication::Server#append is called from several places, that runs some code even though there are no followers, using unnecessary resources. This returns early from append if the follower array is empty.
HOW can this pull request be tested?
Run specs