Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native keychain bindings if possible #7743

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Use native keychain bindings if possible #7743

wants to merge 1 commit into from

Commits on May 20, 2024

  1. Use native keychain bindings if possible 

    Switch from github.com/zalando/go-keyring to github.com/99designs/keyring
that uses native bindings on macOS and Windows.

On darwin, github.com/zalando/go-keyring encodes secret data in hex or
base64, adding a prefix indicating that. If new library returns this
prefix, convert the secret to plain data to keep using existing token
and not require reauthentication.

Originally suggested in cli#7023 (comment)
Fixes cli#7123
    @YorikSar
    YorikSar committed May 20, 2024
    Configuration menu
    Copy the full SHA
    7a55107 View commit details
    Browse the repository at this point in the history