Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS pkg installer to deployment (#7554) #7555

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Add macOS pkg installer to deployment (#7554) #7555

wants to merge 3 commits into from
+145 −2

Conversation

paulober
Copy link

@paulober paulober commented Jun 8, 2023

@paulober paulober requested a review from a team as a code owner June 8, 2023 15:23
@paulober paulober requested review from williammartin and removed request for a team June 8, 2023 15:23
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Jun 8, 2023
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Jun 8, 2023
@paulober paulober force-pushed the feature-macos-pkg-installer branch from 3abfe1a to a2e6927 Compare June 8, 2023 15:27
@williammartin williammartin added blocked discuss Feature changes that require discussion primarily among the GitHub CLI team labels Jun 8, 2023
@paulober
Copy link
Author

paulober commented Jun 8, 2023

See the connected issue for more details on the implementation

@williammartin williammartin requested review from vilmibm and removed request for williammartin June 29, 2023 19:23
@paulober paulober force-pushed the feature-macos-pkg-installer branch from a2e6927 to f1c3534 Compare July 7, 2023 10:01
@paulober
Copy link
Author

paulober commented Sep 4, 2023

@vilmibm @williammartin Any updates on this?

@williammartin
Copy link
Member

@paulober Sorry that your PR is languishing in review purgatory, when I went on parental leave I asked @vilmibm to take ownership but he has since left GitHub. I have not forgotten about it and we are currently figuring out how to deal with our PR backlog with team churn.

@williammartin williammartin requested review from williammartin and removed request for vilmibm September 11, 2023 15:57
@samcoe samcoe removed the discuss Feature changes that require discussion primarily among the GitHub CLI team label Oct 30, 2023
@cli cli deleted a comment Nov 1, 2023
@paulober
Copy link
Author

Will my work now finally after nearly one year be accepted and merged, or should i just delete it and distribute a gh pkg for macOS on my own?

(You are currently maintaining 12 artifacts for linux with 3 different packages per one of the 4 supported architectures.
And macOS people still have to install it manually from a zip folder or rely on a heavy third-party tool.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williammartin williammartin Awaiting requested review from williammartin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked external pull request originating outside of the CLI core team
Projects
No open projects
The GitHub CLI
  
Needs review 🤔
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add macOS pkg installer
4 participants
@paulober @williammartin @samcoe @cliAutomation