Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue create --editor #7193

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Add issue create --editor #7193

wants to merge 1 commit into from
+260 −16

Conversation

notomo
Copy link

@notomo notomo commented Mar 19, 2023

Part of #390

@notomo notomo marked this pull request as ready for review March 19, 2023 06:58
@notomo notomo requested a review from a team as a code owner March 19, 2023 06:58
@notomo notomo requested review from mislav and removed request for a team March 19, 2023 06:58
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Mar 19, 2023
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Mar 19, 2023
@samcoe samcoe requested a review from vilmibm March 22, 2023 23:52
@williammartin
Copy link
Member

williammartin commented Oct 4, 2023 •
edited

Hey @notomo, sorry this PR has sat without review for so long. Since it was opened both @mislav and @vilmibm left the company. I assigned it to myself to review to try and get things moving again. Is this something you are still interested in getting merged in? If so, do you feel like there's anything more you would like to do before I review it?

@notomo
Copy link
Author

notomo commented Oct 4, 2023

@williammartin

Thanks for mentioning!

Is this something you are still interested in getting merged in?

Yes.

If so, do you feel like there's anything more you would like to do before I review it?

Now I resolved conflict. This is ready to review.

@williammartin
Copy link
Member

Alright, thanks for resolving that. Just to give you a heads up, since this work was initially planned in #390, there has been additional discussion around delaying PR/Issue command improvements in light of #7575. It may be that we hold off on merging this until we get more clarity around how we want to approach this other work.

In the meantime, I wanted to make sure you were still interested, and to communicate exactly what the state of this PR is. You have put some work into it and it doesn't look like we've been valuing your time with clear communication. We will try to prioritise this PR and communication going forward.

@williammartin williammartin mentioned this pull request Oct 4, 2023
Open
16 tasks
@williammartin
Copy link
Member

I have also added this PR to the list of improvements on the tracking issue.

@samcoe samcoe added the blocked label Nov 8, 2023
@robinbowes robinbowes mentioned this pull request Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williammartin williammartin Awaiting requested review from williammartin

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked external pull request originating outside of the CLI core team
Projects
No open projects
The GitHub CLI
  
Needs review 🤔
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@notomo @williammartin @vilmibm @samcoe @cliAutomation